Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: usdt protection in antehandler (backport #2315) #2317

Merged
merged 1 commit into from
Sep 23, 2024
Merged

feat: usdt protection in antehandler (backport #2315) #2317

merged 1 commit into from
Sep 23, 2024

Conversation

mergify[bot]
Copy link
Contributor

@mergify mergify bot commented Sep 23, 2024

Changelist

  • Update the doMarketsContainCrossMarket to doMarketsContainRestrictedMarket where USDT/USD is additional restricted market (regardless of having a CROSS perp on it or not).
  • Require the MarketMapKeeper to be passed to the antehandler (previously did not have a check)

Test Plan

  • Tested in antehandler tests
  • full e2e test can be made with a market update transaction against a node

Author/Reviewer Checklist

  • If this PR has changes that result in a different app state given the same prior state and transaction list, manually add the state-breaking label.
  • If the PR has breaking postgres changes to the indexer add the indexer-postgres-breaking label.
  • If this PR isn't state-breaking but has changes that modify behavior in PrepareProposal or ProcessProposal, manually add the label proposal-breaking.
  • If this PR is one of many that implement a specific feature, manually label them all feature:[feature-name].
  • If you wish to for mergify-bot to automatically create a PR to backport your change to a release branch, manually add the label backport/[branch-name].
  • Manually add any of the following labels: refactor, chore, bug.

Summary by CodeRabbit

Summary by CodeRabbit

  • New Features

    • Added validation for the presence of the MarketMapKeeper in the ante handler.
    • Introduced a new variable for the USDT/USD currency pair and updated market validation logic to identify restricted markets.

  • Bug Fixes

    • Enhanced error reporting for restricted markets in the ante handling process.

  • Tests

    • Added test cases to validate market updates for the USDT/USD currency pair, ensuring proper rejection logic is in place.
This is an automatic backport of pull request #2315 done by [Mergify](https://mergify.com).

@mergify mergify bot mentioned this pull request Sep 23, 2024
Merged
6 tasks
@coderabbitai coderabbitai
Copy link
Contributor

coderabbitai bot commented Sep 23, 2024

Important

Review skipped

Bot user detected.

To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    -- I pushed a fix in commit <commit_id>, please review it.
    -- Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    -- @coderabbitai generate unit testing code for this file.
    -- @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    -- @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    -- @coderabbitai read src/utils.ts and generate unit testing code.
    -- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    -- @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@chenyaoy chenyaoy self-requested a review September 23, 2024 16:02
@chenyaoy chenyaoy merged commit 6279caa into release/protocol/v6.x Sep 23, 2024
24 checks passed
@chenyaoy chenyaoy deleted the mergify/bp/release/protocol/v6.x/pr-2315 branch September 23, 2024 16:34
chenyaoy added a commit that referenced this pull request Sep 23, 2024
@chenyaoy
Revert "feat: usdt protection in antehandler (backport #2315) (#2317)"
4989313 
This reverts commit 6279caa.
@chenyaoy chenyaoy mentioned this pull request Sep 23, 2024
Merged
@chenyaoy chenyaoy restored the mergify/bp/release/protocol/v6.x/pr-2315 branch September 24, 2024 18:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chenyaoy chenyaoy chenyaoy approved these changes

Assignees
No one assigned
Labels
protocol
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@chenyaoy @aljo242